Add support for checking for Multi* geometries in BDD tests #2417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geofabrik doesn't see to have osm.bz2 files anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new syntax options for expressing a geometry in the BDD tests:
will mean that you expect a MULTI* geometry. The geometries need to be of the same type, obviously.
means to expect a GEOMETRYCOLLECTION. The inner geometries can be arbitrary simple types. No multi geometries, no collections.
This makes the tests involving multi geometries and collections considerably simpler. It incidentally also works around a bug with ST_GeometryN in PostGIS 3.6.0.
NB: also changes the CI to using pbf for tests as xml files are not offered anymore by Geofabrik.